Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: address screening #1017

Merged
merged 25 commits into from Aug 12, 2022
Merged

feat: address screening #1017

merged 25 commits into from Aug 12, 2022

Conversation

grothem
Copy link
Collaborator

@grothem grothem commented Aug 11, 2022

Prevents wallets that are sanctioned or have known links to terrorist financing from using the interface. Leverages the TRM wallet screening functionality to screen the connected account.

@grothem grothem changed the title feat: block sanctioned wallets feat: address screening Aug 11, 2022
@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Aug 11, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 505 KB (🟡 +15.23 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 38.46 KB (🟢 -15.83 KB) 543.45 KB
/faucet 21.84 KB (🟢 -15.83 KB) 526.84 KB
/governance 63.52 KB (🟢 -16.08 KB) 568.52 KB
/governance/proposal 104.48 KB (🟢 -16.09 KB) 609.48 KB
/governance/proposal/[proposalId] 59.21 KB (🟢 -16.08 KB) 564.21 KB
/markets 11.92 KB (🟢 -16.07 KB) 516.92 KB
/reserve-overview 57.1 KB (🟢 -16.39 KB) 562.09 KB
/staking 32.27 KB (🟢 -15.84 KB) 537.27 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@bojanaave
Copy link
Contributor

bojanaave commented Aug 12, 2022

All of the screens are blocked on the app.aave.com domain, but I'm still able to connect with classic aave can we block classic as well?
Screen Shot 2022-08-12 at 09 34 51

@MareskoY
Copy link
Contributor

@grothem need to add disconnect button for blocked modal

@github-actions
Copy link

drewcook
drewcook previously approved these changes Aug 12, 2022
Copy link
Contributor

@drewcook drewcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@github-actions
Copy link

Copy link
Collaborator

@defispartan defispartan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@defispartan defispartan merged commit 01a9666 into main Aug 12, 2022
@defispartan defispartan deleted the feat/trm-compliance branch August 12, 2022 17:10
twur added a commit to twur/interface that referenced this pull request Aug 13, 2022
bvanderdrift added a commit to bvanderdrift/aave-ui that referenced this pull request Aug 13, 2022
vacekj added a commit to vacekj/uncensored-aave that referenced this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants